Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dismissing to complete the current step #33

Closed
josh-burton opened this issue Jun 16, 2020 · 5 comments
Closed

Allow dismissing to complete the current step #33

josh-burton opened this issue Jun 16, 2020 · 5 comments

Comments

@josh-burton
Copy link

It seems that dismissing the step by tapping the barrier rather than the tap target does not complete the step.

In my case we want the step to be completed regardless of where the user taps. Could this be added?

@ayalma
Copy link
Owner

ayalma commented Jun 17, 2020

It's normal action of library
If you want to complete on dismiss just set sharedPref with featureId key and true value in onDismiss
and that's make the step complete

onDismiss: ()async{
       // set bool to shared pref with key same as featureId and value of true
       return true;
},

@josh-burton
Copy link
Author

Ok, yeah I have a similar work around but I still think it should be a feature of the library.

A flag to configure whether dismissing completes the step.

@ayalma ayalma closed this as completed Jun 18, 2020
@ayalma ayalma reopened this Jun 18, 2020
@ayalma
Copy link
Owner

ayalma commented Jun 18, 2020

Its add extra check to on dismiss while it's not necessary

@ayalma ayalma closed this as completed Jun 18, 2020
@josh-burton
Copy link
Author

It's a shame this was closed. This is a nice library and this small feature would be useful to me and others as well.

It may not be necessary for your use case, or every use case, but it would still be useful.

I guess I'll look for another library.

@ayalma
Copy link
Owner

ayalma commented Jun 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants