Migrate to null safety

[nilsreichardt]

Description

I propose this pull request to migrate this plugin to null safety as it is the way to go now that Flutter 2 has been released.

Here are the changes I introduced:

• Update SDK dependency version to 2.12.0+
• Run dart migrate on existing code to remove unsafe nulls (for the package & example)
• Changed FlatButton to TextButton and RaisedButton to ElevationButton
• Add a new version (0.14.0) to the changelog

Please check everything twice!

Testing

• All existing Tests are passing
• Tested it manually on a Android emulator

Demo:

Screen.Recording.2021-03-06.at.01.10.14.mov

Related tickets

Closes #67

[blaueeiner]

Hi. You should maybe support compatibility with provider: 5.0.0-nullsafety.5 because flutter_bloc currently does not support 5.0.0 yet and it causes versioning issues.

[nilsreichardt]

Hi @blaueeiner! As you can see in felangel/bloc#2202 flutter_bloc will be updated today / tomorrow and after this there should be no versioning conflicts.

[luckyhandler]

nice work!

[sangTroo]

Hi,
Thanks for the great work
When This new version will be available on pub.dev?

[JaffaKetchup]

Hi, any news on this?

[nilsreichardt]

As long as the PR has not been merged, you can use this in your pubspec.yaml:

feature_discovery:
  git:
    url: https://github.com/nilsreichardt/feature_discovery
    ref: migrate-null-safety

[JaffaKetchup]

Hi @nilsreichardt.
Thanks for the tip, however I'm already using it like that. I just don't like having packages from git in my code if I can help it. :)

[nilsreichardt]

@JaffaKetchup Yes, I understand this. If I delete the migrate-null-safety branch / my repo / rename my GitHub username, etc., your code would break 😬

[nosmirck]

any news on when will this be merged?

[JaffaKetchup]

Hi,
Any news on this?
Thanks.

[jagomf]

@ayalma, the owner of this repo, has not given any proof of life since last commit on January. His website, as reported by his bio, is also offline.

It is not a good idea to rely on a package that cannot be maintained. The best option would probably be for anyone that can maintain this to publish the package.

@nilsreichardt would you be willing to publish and maintain this package maybe?

[nilsreichardt]

@jagomf I'm sorry, but I don't have to maintain this package 😖 Maybe @fluttercommunity can do this?

[ayalma]

I'm in nowruz holiday , and cuz of that I can't do anything for that

…

On Sat, Mar 27, 2021, 15:59 Nils Reichardt ***@***.***> wrote: @jagomf <https://github.com/jagomf> I'm sorry, but I don't have to maintain this package 😖 Maybe @fluttercommunity <https://github.com/fluttercommunity> can do this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXZKRDEQ4CQVWFDIJW2VDTTFW6TJANCNFSM4YWDI6HA> .

[nosmirck]

I'm in nowruz holiday , and cuz of that I can't do anything for that

@ayalma so maybe by April 12 we'll have this merged?

[ayalma]

I'll give it a try

…

On Mon, Mar 29, 2021, 06:19 Luis Pulido ***@***.***> wrote: I'm in nowruz holiday , and cuz of that I can't do anything for that @ayalma <https://github.com/ayalma> so maybe by April 12 we'll have this merged? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXZKRH3NXRX6Y6EDOVDGJ3TF7MCPANCNFSM4YWDI6HA> .

[ayalma]

@nilsreichardt @blaueeiner @JaffaKetchup @luckyhandler @sangTroo published to pubspec.