bind_option函数bug？

[LLouice]

这个设置 buffer local 变量的函数对于 false 的处理是有bug吧？

nvimdots/lua/core/options.lua

Lines 3 to 11 in cfaea09

	local function bind_option(options)
	for k, v in pairs(options) do
	if v == true or v == false then
	vim.cmd('set ' .. k)
	else
	vim.cmd('set ' .. k .. '=' .. v)
	end
	end
	end

[1096015776]

Hi，thanks, I test it.
yes, there all setting is true
false is not work
maybe use vim.opt setting can work.
if you want to change these so easy
let vim.opt setting like wrap
vim.opt.wrap=false.
maybe just author's default settings,the setting is ok.
because no opt ,almost the opt is false.

[ayamir]

如果直接给我个pr就更好了

[LLouice]

在我本地测试 buffer local 的 relative number 和 wrap 不生效，我改成了

local function bind_option(options)
    for k, v in pairs(options) do
        if v == true then
            vim.cmd('set ' .. k)
        elseif v == false then
            vim.cmd('set no' .. k)
        else
            vim.cmd('set ' .. k .. '=' .. v)
        end
    end
end

不知道是不是所有的 false 都可以通过no前缀设置，如果不是的话就使用 vim.opt

[LLouice]

@ayamir 另外目前没有抽离出自定义的入口，我都是通过改动原文件修改的，这样同步github改动就很麻烦，希望作者添加一下个人自定义配置的 feature

[1096015776]

you can fork the origin ,then add branch,when change,you can merge,as i know,it is easy to do it.
if you just want to add plugin,you can mkdir the dir to the module , that you can no merge

[LLouice]

@1096015776 yes, we can do it by cloning a new local repo or creating a new branch.
But i think it's bettter if we have a entry for private config.
Personal configuration is not in git and has a higher priority than default.

[1096015776]

yes,i think it is better,I just give you a temp answer to solve that.

[ayamir]

@ayamir 另外目前没有抽离出自定义的入口，我都是通过改动原文件修改的，这样同步github改动就很麻烦，希望作者添加一下个人自定义配置的 feature

这个并不是我想做的，同时目前也没有精力去做，你想要的可能是lunarvim