Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customized neovide and gui config #1033

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Oct 21, 2023

This PR did two things.

  • Separate the config of guifont and neovide.
  • Add two settings entrys in lua/core/settings.lua named as gui_config and neovide_config.

This PR is backward-compatible.

Signed-off-by: ayamir <lgt986452565@gmail.com>
Signed-off-by: ayamir <lgt986452565@gmail.com>
@ayamir ayamir requested a review from Jint-lzxy October 21, 2023 14:02
Signed-off-by: ayamir <lgt986452565@gmail.com>
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 87066d7 into main Oct 23, 2023
4 checks passed
@ayamir ayamir deleted the feat/custom-neovide-config branch October 23, 2023 04:00
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Oct 23, 2023
* feat: move neovide config to settings.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* docs: add comment for new entrys.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* docs: add more NOTEs.

Signed-off-by: ayamir <lgt986452565@gmail.com>

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
ttbug pushed a commit to ttbug/nvimconf that referenced this pull request Oct 26, 2023
* feat: move neovide config to settings.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* docs: add comment for new entrys.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* docs: add more NOTEs.

Signed-off-by: ayamir <lgt986452565@gmail.com>

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants