perf(ts-context): limit max_lines to 3
#1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that when navigating through syntax trees of great intricacy, `ts-context` would expend an excessive amount of time collecting _(and rendering)_ all "candidate nodes" from here to the root of the tree when the cursor goes deep into a particular "branch", given our current settings. This PR limited `max_lines` to 3, as IMO we seldom need hierarchical information about nodes that are _too_ distant from the current one in practice, and `3` is also the optimal value I've found in recent trials that strikes a balance between the amount of practical information and performance penalties lol
ayamir
approved these changes
Nov 23, 2023
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Nov 27, 2023
It appears that when navigating through syntax trees of great intricacy, `ts-context` would expend an excessive amount of time collecting _(and rendering)_ all "candidate nodes" from here to the root of the tree when the cursor goes deep into a particular "branch", given our current settings. This PR limited `max_lines` to 3, as IMO we seldom need hierarchical information about nodes that are _too_ distant from the current one in practice, and `3` is also the optimal value I've found in recent trials that strikes a balance between the amount of practical information and performance penalties lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that when navigating through syntax trees of great intricacy,
ts-contextwould expend an excessive amount of time collecting (and rendering) all "candidate nodes" from here to the root of the tree when the cursor goes deep into a particular "branch", given our current settings. This PR limitedmax_linesto 3, as IMO we seldom need hierarchical information about nodes that are too distant from the current one in practice, and3is also the optimal value I've found in recent trials that strikes a balance between the amount of practical information and performance penalties lol