Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(script): skip dependency installation by default #1114

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

Jint-lzxy
Copy link
Collaborator

IMO the default choice for dependency installation in install.ps1 is a bit misleading (see Discussion #1106). afaik most users won't even "visit" the dynamic provider feature of Neovim, and those who know what they're doing can still continue with the dependency installation by typing Y/y. So I think a more reasonable default should be N (i.e. skipping provider installation altogether.)

IMO the default choice for dependency installation in `install.ps1`
is a bit misleading (see Discussion #1106). afaik most users won't
even "visit" the dynamic provider feature of Neovim, and those who
know what they're doing can still continue with the dependency
installation by typing `Y/y`. So I think a more reasonable default
should be `N` (i.e. skipping provider installation altogether.)
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

@ayamir ayamir merged commit 993ee53 into main Dec 25, 2023
4 checks passed
@ayamir ayamir deleted the feat(deps)/script-more-sensible-default branch December 25, 2023 14:40
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Dec 29, 2023
IMO the default choice for dependency installation in `install.ps1`
is a bit misleading (see Discussion ayamir#1106). afaik most users won't
even "visit" the dynamic provider feature of Neovim, and those who
know what they're doing can still continue with the dependency
installation by typing `Y/y`. So I think a more reasonable default
should be `N` (i.e. skipping provider installation altogether.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants