Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: search with selection text. #1175

Merged
merged 2 commits into from
Feb 15, 2024
Merged

feat: search with selection text. #1175

merged 2 commits into from
Feb 15, 2024

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Feb 13, 2024 •
edited

image

@ayamir
feat: search with selection text.
182dfe6 
Signed-off-by: ayamir <lgt986452565@gmail.com>
@CharlesChiuGit
Copy link
Collaborator

i'll take a look when i get back to work. no pc by hand now lol.

@ayamir
Copy link
Owner Author

ayamir commented Feb 13, 2024

Wonder why the code lint was not passed. 🤨

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Feb 15, 2024 •
edited

Wonder why the code lint was not passed. 🤨

Checking lua/keymap/tool.lua                      1 warning

    lua/keymap/tool.lua:136:56: accessing undefined variable _buf_vtext

lol

@CharlesChiuGit
Copy link
Collaborator

functionality it works

@CharlesChiuGit
Copy link
Collaborator

b3ed6ca (#1175)

this might do the trick lol

CharlesChiuGit
CharlesChiuGit approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! very useful feature lol

@ayamir ayamir merged commit ccd5eda into main Feb 15, 2024
4 checks passed
@ayamir ayamir deleted the feat/search-selection-text branch February 15, 2024 10:24
@TonyWu20 TonyWu20 mentioned this pull request Feb 16, 2024
Merged
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Feb 26, 2024
@ayamir @CharlesChiuGit
feat: search with selection text. (ayamir#1175)
659a64f 
* feat: search with selection text.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(ci): ignore linting

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: CharlesChiuGit <charleschiu@hey.com>
misumisumi pushed a commit to misumisumi/nvimdots that referenced this pull request Mar 5, 2024
@ayamir @CharlesChiuGit @misumisumi
feat: search with selection text. (ayamir#1175)
252d198 
* feat: search with selection text.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(ci): ignore linting

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: CharlesChiuGit <charleschiu@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesChiuGit CharlesChiuGit CharlesChiuGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ayamir @CharlesChiuGit