Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(global): cleanup legacy code #1296

Merged
merged 1 commit into from
Jun 18, 2024
Merged

chore(global): cleanup legacy code #1296

merged 1 commit into from
Jun 18, 2024

Conversation

Jint-lzxy
Copy link
Collaborator

All of these "workarounds" should no longer be necessary since Neovim v0.6 or so.


Created with gh pr create

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 7e11cdc into 0.10 Jun 18, 2024
4 checks passed
@ayamir ayamir deleted the chore/cleanup-legacy-code branch June 18, 2024 14:09
Jint-lzxy added a commit that referenced this pull request Jul 1, 2024
* feat: implement inlay virtual text for rust and go (#759)

* feat: implement inlay virtual text for rust and go

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>

* fix: go-nvim use lsp-inlayhints.nvim only

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>

* refactor: move inlay-hints to `completion`

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>

* feat: lua support

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>

* chore(inlay-hints): remove `sumneko_lua`

* fix: set inlay-hints debug mode off

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>

---------

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
Co-authored-by: Charles Chiu <charleschiu@hey.com>

* workaroud for watchfile problem (#871)

* workaroud for watchfile problem

* fix CI

* Merge branch 'main'

* chore(neodim): remove pin commit (#1142)

Signed-off-by: Charles Chiu <charleschiu@hey.com>

* fix: remove `specs.nvim` due to long time no update.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* Merge branch 'main' into 0.10

Signed-off-by: ayamir <lgt986452565@gmail.com>

* refactor: use neovim native inlay-hint.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fix(lsp): adapt to upstream API, eliminate warning.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fix(plugins): add nvim-bqf.

* fix(go.nvim): adapt upstream api.

* feat(plugins): add dropbar.nvim for winbar.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* feat(settings): make enable_inlayhint configurable.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fixup: check user input, improve robustness.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fix(clangd): disable clangd for proto.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fixup: clean redundant config files.

* fix(gopls): unify gopls config, allow user overrides.

* fixup: clean code.

* feat(clang_format): enable clang_format for cuda and protobuf.

* fix: inlay_hint error (#1236)

* Merge remote-tracking branch 'origin' into 0.10

* fix: lua_ls workspace settings.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore: upgrade to new api to judge if is a list.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore: use builtin grep_string to search selection.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore: general cleanup

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix: `inlayhint` -> `inlayhints`

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(ts-autotag): update config format

* chore: use vim.uv in place of vim.loop.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore: use vim.iter():flattern in place of vim.tbl_flattern.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore: update install scripts for nvim 0.10 stable. (#1271)

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore: replace deprecated apis (#1266)

* chore: use vim.lsp.get_clients in place of vim.lsp.get_active_clients.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore: use vim.lsp.get_clients in place of vim.lsp.buf_get_clients.

Signed-off-by: ayamir <lgt986452565@gmail.com>

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fix(toggleterm): use `""` instead of `nil` to fix auto-exit on Windows (#1267)

* fix: utilize `ts-context` in `glance` preview window (#1265)

* set ts-context floatterm zindex to 50 which greater than 45.

default zindex of glance [dnlhc/glance.nvim] floatterm is 45.
It can display on glance.

Signed-off-by: mjkx <291083247@qq.com>

* set trim_scope to inner

Signed-off-by: mjkx <291083247@qq.com>

* perf: add discription

---------

Signed-off-by: mjkx <291083247@qq.com>
Co-authored-by: CharlesChiuGit <charleschiu@hey.com>

* chore: use vim.o in place of vim.api.nvim_get_option_value. (#1269)

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fix(0.10): minor cleanup (#1276)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(scripts): update frequently used functions (#1277)

I recently refactored my frequently used commands and
thought it would be great to also port that here lol

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(docs): support v0.10 (#1278)

* feat(docs): support v0.10

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix instructions

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

---------

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(scripts): typo

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fixup! fix(scripts): typo

* feat(README): supports `0.9` -> `0.10`

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* chore: cleanup

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(lualine): ensure all components are properly aligned

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* unlock rustaceanvim

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(lsp): be protective

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix: `neovim` -> `Neovim`

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* Revert "fix(lualine): ensure all components are properly aligned"

This reverts commit 9be7ffe.

* feat: support new options (#1279)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(trouble)!: v3 support (#1281)

* feat(trouble)!: v3 support

This PR includes the following changes:

- *REMOVED* all features unrelated to the original purpose of
  trouble.nvim, such as LSP References (Glance.nvim covers this) and
  qf-list preview (bqf handles this).

- Added a custom mapping for searching project diagnostics. This is
  slightly different from workspace diagnostics: one is defined by
  the language server itself (e.g., see LuaLS's documentation on workspace
  diagnostics), while the other is determined with assistance from Project.nvim.

- General cleanup: I deliberately excluded LspKind support from our
  config this time bc imho it's a feature we likely won't use and
  supporting it is a real hassle.

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fixup! Missing one option

* fix: invoke `utils.load_plugin`

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

---------

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* refactor: overhaul the icon library (#1282)

This PR significantly updates the icon library by expanding its
content, removing duplicates, and organizing icons into more cohesive
groups.

I've also created a custom Dropbar config that uses these icons and
adds toggleterm support.

* fix typo

* Oops... Missing one icon

* fix: invoke `utils.load_plugin`

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(lsp): correctly configure diagnostic-signs (#1280)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat: disable more plugins for RO (buf|file)types (#1284)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(alpha): cannot cast `string` to `integer` for winheight (#1285)

iirc this is deprecated

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(ibl): support per-language indent config (#1287)

* feat(ibl): support per-language indent config

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fixup! feat(ibl): support per-language indent config

---------

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(ibl): more language nodes (#1288)

* feat(ibl): more language nodes

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(ibl): even more language nodes

Signed-off-by: Charles Chiu <charleschiu@hey.com>

* chore(ibl): sorting

Signed-off-by: Charles Chiu <charleschiu@hey.com>

---------

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: Charles Chiu <charleschiu@hey.com>

* feat(luasnip): support ECMAScript regexes (#1291)

As per `:h luasnip-lsp-snippets-transformations`

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(core): use the lua API to set options (#1292)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat: include several new plugins (#1235)

* feat(cmp): more completion candidates from opened buffers. (#1219)

* buffer completion config

* opts -> option

* chore(lockfile): auto update lazy-lock.json

* chore(plugins): tidying up (#1221)

This commit mainly tweaks the loading events of some plugins to align with
upstream specifications. Additionally, there have been enhancements made to
certain documentation.

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(plugins): remove duplicate specifications

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix: use `init` for vim plugins (#1222)

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(lockfile): auto update lazy-lock.json

* docs: mention the experimental nature of the 0.10 branch (#1215)

* docs: add note for 0.10 nightly branch in readme.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(issue_template): add nightly warning

Signed-off-by: Charles Chiu <charleschiu@hey.com>

* chore(issue_tempate): linting

Signed-off-by: Charles Chiu <charleschiu@hey.com>

* docs: update readme for 0.10 branch.

Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* chore(issue_template): add nightly warning

Signed-off-by: Charles Chiu <charleschiu@hey.com>

* chore(issue_template): add nightly warning

Signed-off-by: Charles Chiu <charleschiu@hey.com>

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Signed-off-by: Charles Chiu <charleschiu@hey.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>
Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Co-authored-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(ISSUE_TEMPLATE): format code

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(README): misplaced content

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(todo-comment): add missing keywords (#1225)

Signed-off-by: Charles Chiu <charleschiu@hey.com>

* chore(lockfile): auto update lazy-lock.json

* fix(options): remove options managed by `vim-sleuth` (#1229)

Since all tab-related stuff is now managed by `vim-sleuth`, I think
it is better to remove the relevant options to avoid confusion.

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* chore(lockfile): auto update lazy-lock.json

* fix(rustaceanvim): use `init` for its config (#1231)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* chore(lockfile): auto update lazy-lock.json

* feat!: improve go development experience (#1226)

* chore(go): replace vim-go with go.nvim.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fix: install gopls by mason by default.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* feat(keymap): set `n|gi` to goto implementation.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore(keymap): use `gm` to jump to lsp implementations

Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* fixup: remove unused `map_cu`.

* chore: use gopls instead of null-ls to format.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* chore: add notes for config options.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fixup: tidy settings for go.nvim and gopls.

* docs: update more notes for how to config go.nvim.

* chore: cleanup

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix: enable only the options that are truly necessary

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fixup! chore: cleanup

* fix(gopls): invalid config entry

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>
Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com>
Co-authored-by: neogtliu <neogtliu@tencent.com>

* feat!: add `advanced-git-search.nvim`

* feat!: add `search.nvim` to enhance `telescope`.

* feat: reorganize keymaps for telescope search collections.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fixup: update descriptions for modified keymaps.

* chore: remove single diagnostic disable for undefined-field.

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* chore: remove diagnostic disable for undefined-field.

* feat!: replace `colorizer.lua` with `nvim-highlight-colors`

* fix: invoke `utils.load_plugin`

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* chore(advanced-git-search): remove unused options

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(telescope): add collection panel for `search.nvim`

* chore: typo

* feat: more documentation

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* chore: clean up

* feat: don't hard-code collection names

* chore: use custom loader

* fix: disable warning

* fix: CI & cleanup

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* Revert `lazy-lock.json`

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix: make luaJIT happy

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

---------

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: ayamir <lgt986452565@gmail.com>
Signed-off-by: Charles Chiu <charleschiu@hey.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>
Co-authored-by: mjkx <52132505+mjkx5@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com>
Co-authored-by: Mohu <lgt986452565@gmail.com>
Co-authored-by: neogtliu <neogtliu@tencent.com>

* feat: better way to check if the (T|G)UI is running (#1297)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* chore(global): cleanup legacy code (#1296)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat: reduce the use of direct syscalls (#1294)

* feat: reduce the use of direct syscalls

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix: typo

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

---------

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(events): avoid name clashes (#1295)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* Feat/telescope collections keymaps (#1299)

* feat(telescope): add some new plugins for `search.nvim`

* fixup: correct alpha-nvim config.

* feat: more resonable keymap, add notify to misc.

Signed-off-by: ayamir <lgt986452565@gmail.com>

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: ayamir <lgt986452565@gmail.com>

* fix(gitsigns): upstream breaking changes (#1300)

See lewis6991/gitsigns.nvim@3d7e49c

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(core): missing leading path separator (#1301)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* Revert "Feat/telescope collections keymaps (#1299)" (#1302)

This reverts commit 93c06cd.

* Feat/telescope collections keymaps (#1303)

* feat(telescope): add some new plugins for `search.nvim`

* fixup: correct alpha-nvim config.

* feat: more resonable keymap, add notify to misc.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* revert: local cmp changes.

* fix: update alpha-nvim config.

* chore: update doc strings

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* Update lua/modules/configs/ui/alpha.lua

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* Update lua/modules/configs/ui/alpha.lua

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* Update lua/modules/configs/ui/alpha.lua

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* Update lua/modules/configs/ui/alpha.lua

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* Update lua/modules/configs/ui/alpha.lua

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* feat: update dotstutor.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* feat: correct several minor issues

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* chore: cleanup

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat!: mnemonic keymaps

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>
Co-authored-by: CharlesChiuGit <charleschiu@hey.com>
Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(treesitter): lessened performance restrictions (#1305)

* feat(treesitter): lessened performance restrictions

This commit lifts some of the performance restrictions previously imposed on
Treesitter when incremental parsing was not yet supported. Specifically:

Treesitter will now only be disabled by default for files exceeding 7,500 lines
or 2 MiB in size. Testing on an Intel i9-9880H with an APPLE SSD AP1024N shows
noticeable lag at these thresholds.

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fixup: return correct value.

---------

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Co-authored-by: ayamir <lgt986452565@gmail.com>

* chore: update plugin author's name

Signed-off-by: Charles Chiu <charleschiu@hey.com>

* feat(nixos): add `mergeLazyLock` option (#1310)

* feat(nixos): add copyLazyLock option

* fix(nixos): fix code style

accepted modification proposed by nixd
see more nix's code style best practice below url
https://nix.dev/guides/best-practices

* fix(nixos): rename copyLazyLock to mergeLazyLock

* fix(nixos): fix discription

* fix: cmp snippets source selecting issue (#1309)

* migrate(cmp): `cmp_nvim_lsp` capabilities API update

* feat(cmp): make `<CR>` safer

* fix(cmp): occasional inability to select completion items (#1315)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: ayamir <lgt986452565@gmail.com>

* feat: credit all collaborators as copyright holders (#1316)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat: make format timeout configurable (#1275)

* feat&refactor: make format timeout configurable, refactor format-related
options.

* chore(settings): set `format_modifications_only` to `false` to prevent possible ci issues

Signed-off-by: Charles Chiu <charleschiu@hey.com>

* fix: set timeout for null-ls considering range format capability.

this commit also revert the settings structure b/c we can refactor it in
another PR.

* fixup: fix ci.

* fix: remove redundant notification.

* fixup: fix notify logic and CI.

* fixup: merge judgements.

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>

* fixup: remove redundant judge.

* docs: more accurate comment note.

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: ayamir <miracle_l@bupt.edu.cn>

* fix: wrong require source.

Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: ayamir <miracle_l@bupt.edu.cn>

---------

Signed-off-by: Charles Chiu <charleschiu@hey.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>
Signed-off-by: ayamir <miracle_l@bupt.edu.cn>
Co-authored-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>

---------

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
Signed-off-by: ayamir <lgt986452565@gmail.com>
Signed-off-by: Charles Chiu <charleschiu@hey.com>
Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: mjkx <291083247@qq.com>
Signed-off-by: Mohu <miracle_l@bupt.edu.cn>
Signed-off-by: ayamir <miracle_l@bupt.edu.cn>
Co-authored-by: ClSlaid <cailue@bupt.edu.cn>
Co-authored-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: Xie Zejian <xiezej@gmail.com>
Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Co-authored-by: Mythos_404 <mythos_404@outlook.com>
Co-authored-by: mjkx <52132505+mjkx5@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: neogtliu <neogtliu@tencent.com>
Co-authored-by: MiSumiSumi <dragon511southern@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants