Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(icon): add cmp icons for codeium and tabnine #600

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

CharlesChiuGit
Copy link
Collaborator

Without these icons, cmp will throw errors when showing suggestion windows.
No very creative tho lol

@CharlesChiuGit CharlesChiuGit changed the title perf(icon): add cmp icon for codeium and tabnine perf(icon): add cmp icons for codeium and tabnine Mar 27, 2023
@CharlesChiuGit CharlesChiuGit added the cmp Nvim-cmp related issues label Mar 27, 2023
@Jint-lzxy
Copy link
Collaborator

Perhaps \uf1ab is a better alternative?

@CharlesChiuGit
Copy link
Collaborator Author

But nvim_lsp is using the same icon?

@Jint-lzxy
Copy link
Collaborator

But nvim_lsp is using the same icon

Yep, but nvim_lsp is not used anywhere in this config. IMO using the same icon as nvim_lsp could clearly indicate that this is a feature related to nvim_lsp, but there is no icon available for that specific source.

Perhaps this way users can better understand the intent of this icon rather than using an unrelated one \uf0d0?

lua/modules/utils/icons.lua Outdated Show resolved Hide resolved
@ayamir
Copy link
Owner

ayamir commented Mar 28, 2023

IMO new icons are needed. They usually give completion by sentence or paragraph, which is different from traditional lsp client's behavior. Maybe nf-cod-symbol_keyword in nerd font is a good choice?

@CharlesChiuGit
Copy link
Collaborator Author

IMO new icons are needed. They usually give completion by sentence or paragraph, which is different from traditional lsp client's behavior. Maybe nf-cod-symbol_keyword in nerd font is a good choice?

That makes a lot of sense. Updated!

@ayamir ayamir merged commit 6be63d7 into ayamir:main Mar 30, 2023
@CharlesChiuGit CharlesChiuGit deleted the perf/icon-update branch March 30, 2023 08:51
boomker pushed a commit to boomker/uvcode-nvim that referenced this pull request Apr 4, 2023
perf(icon): add cmp icons for `codeium` and `tabnine`

(cherry picked from commit 6be63d7)
YanTree pushed a commit to YanTree/nvim that referenced this pull request Apr 9, 2023
perf(icon): add cmp icons for `codeium` and `tabnine`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp Nvim-cmp related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants