Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scrollview): enable signs support #808

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

Jint-lzxy
Copy link
Collaborator

@Jint-lzxy Jint-lzxy commented Jun 19, 2023

Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 1a4a588 into ayamir:main Jun 19, 2023
1 check passed
@ayamir
Copy link
Owner

ayamir commented Jun 19, 2023

Seems we can remove the signs showed on the left to simplify ui?

singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Jun 20, 2023
@Jint-lzxy Jint-lzxy deleted the feat/scrollview-signs branch June 20, 2023 12:00
@Jint-lzxy
Copy link
Collaborator Author

But the signs on RHS (or beside the scrollbar) uses relative positions (to the document), FWIW the signs showed on the left are still required for precise positioning.

bleedingfight pushed a commit to bleedingfight/nvimdots that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants