fix(dap-keymap): simplify keymap implementation #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe https://github.com/anuvyklack/keymap-amend.nvim is good to look at |
Jint-lzxy
force-pushed
the
fix/dap-keymap
branch
from
911af98
to
a16fb12
Compare
|
|
Done :D |
ayamir
approved these changes
Jul 28, 2023
YuCao16
pushed a commit
to YuCao16/nvimdots
that referenced
this pull request
Jul 28, 2023
* fix(dap-keymap): simplify keymap implementation * Implement keymap module * fix(dap-keymap)!: simplify keymap implementation
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Jul 28, 2023
* fix(dap-keymap): simplify keymap implementation * Implement keymap module * fix(dap-keymap)!: simplify keymap implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the cognitive complexity of changes introduced by #902 is too high. This PR makes
dap-keymap.luado whatever it should have done - delete old keymaps and restore them when appropriate.