Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you review these changes to Rhino.DSL? #1

Closed
wants to merge 3 commits into from

Conversation

ngbrown
Copy link
Contributor

@ngbrown ngbrown commented Feb 5, 2011

Hi,

I am just now going through your Boo book and I had already downloaded the most recent Boo (0.9.4) and figured I might as well integrate that with your DSL tools. I had to deal with some changes in the Boo library, so see if I did ok. The tests pass, but I might have missed something.

Thanks,

Nathan

…d test project to .NET 3.5 as it was required by Rhino Mocks.
…he MSBuild Task DLL.

Block properties obsoleted and replaced with Body.

The _context field in AbstractTransformerCompilerStep is no longer protected.  To work around it getting set to null, overrode Dispose to do nothing.
@ipashchuk
Copy link

good idea -- I was just doing the same myself.

@ayende
Copy link
Owner

ayende commented Feb 14, 2011

Great, pushed

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants