Made AbstractLicenseValidator implement IDisposable #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the admin tool for easier deployment
-Added saving and exporting of user custom fields for license -Some touches to the style -Ability to add key/values to the license -Made the dialog fixed size
Not sure what "fancy-word"-principle this seems to break but essentially every time you instantiate the AbstractLicenseValidator it would create a timer thread which would never be removed until the garbage collector did its job. This is a very strange behavior because it forces us to call DisableFutureChecks as if it was a dispose method. This opens up the license validator to be used in bigger server environments.
|
Sorry, not sure why it added all these commits (sorry) but essentially only ac279b4 should be the focus. Forgive my lack of gitness |
|
@stemarie the correct way is you should do a pull at the correct version, create a branch. make your changes in that branch then submit a clean pull request from the branch. that way other commits wont be pulled along for the ride. :) |
|
Ok, I understand - sorry - I'm still learning Git's awesomeness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what "fancy-word"-principle this seems to break but essentially every time you instantiate the AbstractLicenseValidator it would create a timer thread which would never be removed until the garbage collector did its job. This is a very strange behavior because it forces us to call DisableFutureChecks as if it was a dispose method. This opens up the license validator to be used in bigger server environments.