Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved the sequenceId to increase before sending, so it always increases #76

Merged
merged 2 commits into from
Nov 29, 2021
Merged

moved the sequenceId to increase before sending, so it always increases #76

merged 2 commits into from
Nov 29, 2021

Conversation

galrose
Copy link
Collaborator

@galrose galrose commented Nov 29, 2021

should fix #75

@galrose galrose self-assigned this Nov 29, 2021
@galrose galrose added the bug Something isn't working label Nov 29, 2021
ronfarkash
ronfarkash approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@ronfarkash ronfarkash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch.

@galrose galrose merged commit df6d956 into main Nov 29, 2021
@galrose galrose deleted the task/fixSequenceId branch November 29, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronfarkash ronfarkash ronfarkash approved these changes

@danielsinai danielsinai danielsinai approved these changes

Assignees

@galrose galrose

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings about messages going to pending queue when there is nothing wrong with the connection.
3 participants
@galrose @ronfarkash @danielsinai