-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for typescript #9
Comments
A great idea. Instead of creating a dependency for this small component or rewriting this component with typescript, it can be sufficient to create only an |
any pr for this? |
No for now. If there is no help from the community, I will solve it this week. @davidkhierl |
seems the recent publish are not properly typed hence had some problem in my project so I made a pr to fully type the project. |
I'm sorry it's so late. TypeScript support is now ready. |
It's always nice to have type information and it would be great to have type information for this awesome package.
I'm thinking to create @types/react-icomoon or maybe even better to just re-write this project (well, single js file) to TypeScript. Then users will know props just from autocompletion for example.
What do you think?
The text was updated successfully, but these errors were encountered: