Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for typescript #9

Closed
iezepov opened this issue Apr 14, 2020 · 5 comments
Closed

Add types for typescript #9

iezepov opened this issue Apr 14, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@iezepov
Copy link

iezepov commented Apr 14, 2020

It's always nice to have type information and it would be great to have type information for this awesome package.

I'm thinking to create @types/react-icomoon or maybe even better to just re-write this project (well, single js file) to TypeScript. Then users will know props just from autocompletion for example.

What do you think?

@aykutkardas
Copy link
Owner

aykutkardas commented Apr 14, 2020

A great idea. Instead of creating a dependency for this small component or rewriting this component with typescript, it can be sufficient to create only an index.d.ts file.

@aykutkardas aykutkardas added the enhancement New feature or request label Apr 17, 2020
@davidkhierl
Copy link

any pr for this?

@aykutkardas
Copy link
Owner

any pr for this?

No for now. If there is no help from the community, I will solve it this week. @davidkhierl

@davidkhierl
Copy link

any pr for this?

No for now. If there is no help from the community, I will solve it this week. @davidkhierl

seems the recent publish are not properly typed hence had some problem in my project so I made a pr to fully type the project.
#13

@aykutkardas
Copy link
Owner

I'm sorry it's so late. TypeScript support is now ready.

v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants