typescript support ☑ #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for this work. I will evaluate this in more detail. I am waiting for a more suitable time for this. @davidkhierl |
|
Hmmm that’s odd seems like the selection.json got updated it have different
properties now
…On Tue, Sep 8, 2020 at 11:51 PM Aykut Kardaş ***@***.***> wrote:
[image: image]
<https://user-images.githubusercontent.com/7966133/92521298-ac7ff480-f225-11ea-8d47-d41117a2c3bc.png>
I generated an selection.json file and tried it. But I am getting some
errors. What is this all about? @davidkhierl
<https://github.com/davidkhierl>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7LZGOKGZSBDZVVNZKMFS3SE2DLTANCNFSM4QJOCIMA>
.
|
I understand the cause of that problem, but there are a number of other shortcomings. Your development is almost available, but still a huge change. I'll merge this once I'm sure enough. |
|
I understand, some of the method won’t work anymore especially the getting
of the current icon and path as the json file have different properties
now. A quick workaround is make the iconSet props to a generic type or cast
it directly
…On Thu, Sep 10, 2020 at 11:06 AM Aykut Kardaş ***@***.***> wrote:
Hmmm that’s odd seems like the selection.json got updated it have
different properties now
I understand the cause of that problem, but there are a number of other
shortcomings. Your development is almost available, but still a huge
change. I'll merge this once I'm sure enough.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7LZGJHNFSQ2NTD3OKKJPTSFB3IXANCNFSM4QJOCIMA>
.
|
|
updated the "iconSet" types, if this got pushed thru I'm planning to have it's own context api for the selection.json so we can utilize hooks for ease in the future, please let me know what you think |
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed project to typescript and did my best to type the selection JSON file from icomoon.io, I quite did the similar approach in my existing project when this package still doesn't support typescript.