-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lang]: add translation to Brazilian Portuguese
#39
Comments
I can help you @rafaelassumpcao. It's would be my first contribution to an open project. I don't know exactly how to work at this point. |
The text of some steps may change so I'll keep this issue open. I am definitely positive about the addition of local languages and I take it seriously. I hope those who want this language to be added send emoji here. I will prepare a roadmap soon. Thank you for your interest. ✨ |
Oh that's awesome, we can divide up some of the work, if you want and end up with 2 complementary PRs, but we should wait for the changes and the road map I think. |
Perfect! Let's wait for the road map |
Brazilian Portuguese
I made some edits to the language files. Now might be a good time to start. @rafaelassumpcao @carlosbarretoeng |
Good to know @aykutkardas So @carlosbarretoeng we can see we could share the remaining work to do. Do you have an idea? |
I was thinking about it. Maybe we could translate each file in the 'localization' folder, each one of us one file, could work's. For control, before starting to translate, we inform here what file will be translated. What do you think about working in forked repositories? Or maybe can we work in the same repository as collaborators? Anyway, we should make a pull request (at least a full commit) for each file translated. This way, if occurs a mistake, would be easier to correct that. I don't know if I made myself understand. What do you think about @aykutkardas and @rafaelassumpcao ? |
As long as you're only sending the changed JSON files, it's okay to send them all in one PR or each file as a separate PR. It is important not to submit a change to this file before all translations are complete. I'm excited for a new language. I'll be here if you have any questions. ✨ |
Hi, I submitted a PR #139 with a partial translation. Can you check, @rafaelassumpcao ? |
I wish to translate it to portuguese if there is no problem to you @aykutkardas
i just havea question, on localization folder, i'm thinking in put the json as 'brazilian-portuguese' to diferentiate the portuguese from portugal one its that ok?
The text was updated successfully, but these errors were encountered: