Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Russian localization #84

Merged
merged 9 commits into from Dec 2, 2021
Merged

Add Russian localization #84

merged 9 commits into from Dec 2, 2021

Conversation

LWJerri
Copy link
Contributor

@LWJerri LWJerri commented Nov 29, 2021 •
edited

  • index.js
  • Translate cheatsheet.json
  • Translate general.json
  • Translate landing.json
  • Translate learn.json

@aykutkardas aykutkardas mentioned this pull request Nov 29, 2021
Closed
@LWJerri
Copy link
Contributor Author

LWJerri commented Nov 30, 2021

Hello, @aykutkardas! Project use ISO 639-1 standard language codes?

@aykutkardas
Copy link
Owner

Hello, @aykutkardas! Project use ISO 639-1 standard language codes?

Hi @LWJerri, of cource.

@LWJerri LWJerri changed the title [WIP] Add Russian localization Add Russian localization Nov 30, 2021
@LWJerri
Copy link
Contributor Author

LWJerri commented Nov 30, 2021

Hello! I added Russian localization for this beautiful project. All changes tested and work perfect =). My PR is ready to review.

@LWJerri LWJerri marked this pull request as ready for review November 30, 2021 23:01
@aykutkardas
Copy link
Owner

I'll do the tests and merge PR in a few days. Looks great. 🚀 ✨

@aykutkardas aykutkardas self-requested a review December 1, 2021 18:01
aykutkardas
aykutkardas requested changes Dec 1, 2021
View reviewed changes
Copy link
Owner

@aykutkardas aykutkardas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some minor changes and suggestions.

@aykutkardas aykutkardas merged commit bfa5f3c into aykutkardas:develop Dec 2, 2021
@LWJerri LWJerri deleted the ru_localization branch December 5, 2021 10:11
@aykutkardas aykutkardas mentioned this pull request Dec 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aykutkardas aykutkardas aykutkardas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LWJerri @aykutkardas