A lot of changes to make 'agentless' and 'port-forward' the mainstream options, now works with containerd. Re-worked README #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.3.3 to 1.4.12. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.3.3...v1.4.12) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…om/containerd/containerd-1.4.12 Bump github.com/containerd/containerd from 1.3.3 to 1.4.12 plus other dependabot deps updates
JamesTGrant
changed the title
pkg/kubectl-debug/cmd line: 698, extra back parentheses
fix(pkg/kubectl-debug/cmd): fix incorrect code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty sure it'll never be accepted as I've removed dependancies away from aylei dockerhub repo. But, this PR might (hopefully) help someone who, like me stumbeled across this excellent project with the same needs as me. Previously it did not work with agentless (missing a mount point), port-forword was not properly the default, the daemonset helm file was obsolete and missing most of the required mountpoints. The readme has been re-written such that the narritive accomodates 'agentless' by default. As I say - this project is brilliant and all credit belongs to @aylei and the folk who did the lcxfs and agentless work.
I've assumed this project is no longer maintained (hence using my dockerhub for the debug-agent pod but am creating this PR in the hope that it helps someone like me in the future.