-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rock64_install_to_emmc.sh #25
Conversation
port of pine64_install_to_emmc.sh; for the rock64; supports xenial-mate|xenial-minimal|xenial-i3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this? As it does not work on the 0.4.17 build, since for starters, the /sys/devices/soc.0/1c10000
is not present (and will probably never be present). Then, the other issue is that it will write to the wrong device. /dev/mmcblk0
is the eMMC, not /dev/mmcblk1
btw, to make the necessary changes, all you need to do is push more commits to the branch on your repo, it will automatically update this PR with any changes you make.
usage | ||
fi | ||
|
||
if [[ ! -d /sys/devices/soc.0/1c10000.sdmmc/mmc_host/mmc1 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't exist on the rock64, needs removing.
echo "" | ||
echo "Using $DOWNLOAD_URL..." | ||
echo "Umounting..." | ||
umount -f /dev/mmcblk1* || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong device. This is the microSD card
echo "" | ||
|
||
echo "Downloading and writing to /dev/mmcblk1..." | ||
curl -L -f "$DOWNLOAD_URL" | $ARCHIVER | dd bs=30M of=/dev/mmcblk1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong device - should be /dev/mmcblk0
exit 1 | ||
fi | ||
|
||
if [[ ! -e /dev/mmcblk1 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ok, but perhaps identifying the actual boot medium is better? Perhaps using the same test used in the resize script? Just a thought.
fi | ||
|
||
case "$1" in | ||
xenial-minimal|xenial-mate|xenial-i3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only these three? Why not also the other currently offered builds? i.e. armhf build, the stretch build, and the jessie-minimal and jessie-omv builds?
@marcushh777 Could you update these scripts? |
Yes , certainly !
…On Sun, Sep 10, 2017 at 2:41 PM, Kamil Trzciński ***@***.***> wrote:
@marcushh777 <https://github.com/marcushh777> Could you update these
scripts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHUT-Uz5L3o4ukDHrCGaedJNuBbN4N5Gks5shDuHgaJpZM4O39lb>
.
--
Kind regards,
Mark H. Harris
|
d8a280d
to
6d754f8
Compare
a4b291f
to
1d02721
Compare
092d477
to
ead4abd
Compare
2f24c70
to
c555d8e
Compare
port of pine64_install_to_emmc.sh; for the rock64;
supports xenial-mate|xenial-minimal|xenial-i3