[refactor] Extend WandbLogger to log config variables, entity and kwargs #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the
WandbLogger
class that was recently added to this library. Since MMF is a config-first framework, it would be great to log the config file to keep track of what's going in the model training/evaluation process.The effect of this small change can be seen through the before and after screenshots. One can compare one experiment from another by comparing the config.
Before:
After:
I have also added another argument to pass
entity
towandb.init
. Explicit mention of this will help users who are using a W&B Teams account.I also saw the
**init_kwargs
argument in theWandbLogger
(logger.py
) class but the same was not passed in theLogisticsCallback
(logistics.py
) class. I might not be using the command line correctly to pass thekwargs
arguments. If that's the case, I will revert back the change and would appreciate it if you can let me know the correct way of doing it.PS: I am learning about this library and will be using it for personal work. Since I am also affiliated with Weights and Biases, I will be creating some PRs to add functionalities to the logger that might be useful for everyone. :)