Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement keyboard shortcuts (commands). #43

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Implement keyboard shortcuts (commands). #43

merged 2 commits into from
Aug 28, 2021

Conversation

jtagcat
Copy link
Contributor

@jtagcat jtagcat commented Aug 26, 2021

Closes #42

Copy link
Owner

@az0 az0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Would you also provide documentation for end users? Even if it is very short, that would be appreciated.

commands/commands.js Outdated Show resolved Hide resolved
manifest.json Outdated Show resolved Hide resolved
@az0
Copy link
Owner

az0 commented Aug 27, 2021

Would you also provide documentation for end users? Even if it is very short, that would be appreciated.

Clarification: you can just type it here, and I will pass it along in the release notes and on the small web site used for documentation. I am not asking you to commit it into the code because there is not a place for it there (yet).

@jtagcat
Copy link
Contributor Author

jtagcat commented Aug 27, 2021

Co-authored-by: Andrew Ziem <ahz001@gmail.com>
@az0
Copy link
Owner

az0 commented Aug 31, 2021

@jtagcat

Are you able to please help make this compatible with Chromium-based browsers (e.g., Google Chrome)? It doesn't have to enable the keyboard shortcuts on Chromium, but as it is now, the extension totally fails to work.

Related issue #47

@az0
Copy link
Owner

az0 commented Sep 3, 2021

I had to revert this for Firefox because it broke the extension for some FIrefox users

@lutzd
Copy link

lutzd commented Sep 3, 2021

hallo my dear
when deactivate xpi certification check, my linkgopher works fine, Thank you!!

screenshot 269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts
3 participants