Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to report raw count values instead of delta values #17

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

fyi-coursera
Copy link
Contributor

Reporting delta values doesn't behave correctly if the application is decrementing the counter.

README.md Outdated
@@ -130,6 +130,7 @@ The reporter provides a fine-grained configuration options through its builder t
.withJvmMetrics()
.withGlobalDimensions("Region=us-west-2", "Instance=stage")
.withZeroValuesSubmission()
.withReportwithReportRawCountValue()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. You want .withReportRawCountValue()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@fyi-coursera
Copy link
Contributor Author

@azagniotov any updates on this PR?

@azagniotov azagniotov merged commit 2d8e8ea into azagniotov:master Aug 20, 2018
@azagniotov
Copy link
Owner

Will release it today! Thank you

@azagniotov
Copy link
Owner

Released v1.0.10 to Maven Central. Please allow a few hours for the new artifact to become live.

@fyi-coursera
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants