high resolution metrics #22
Conversation
| @@ -339,6 +341,7 @@ private void stageMetricDatum(final boolean metricConfigured, | |||
| .withValue(cleanMetricValue(metricValue)) | |||
| .withMetricName(metricName) | |||
| .withDimensions(dimensions) | |||
| .withStorageResolution(highResolution ? 1 : 60) | |||
There was a problem hiding this comment.
What do 1 & 60 mean here? Could you extract them into constants?
There was a problem hiding this comment.
I guess they mean something like "one second resolution" or "sixty seconds/one minute resolution"... AWS doesn't give much away;
The PutMetricData function now accepts an optional StorageResolution parameter. Set this parameter to 1 to publish high-resolution metrics; omit it (or set it to 60) to publish at standard 1-minute resolution.
Since this is CloudWatchReporter internals, I thought that abstracting them using Builder.withHighResolution() would be enough :-)
There was a problem hiding this comment.
ok - got rid of the secret numbers
|
ping |
|
@jebl01 thanks, sorry - real life busy |
|
Will release today! |
|
@jebl01 I released the new version the contain your changes. Thanks for your help. Please allow a few hours for the release to go live on Maven Central |
|
👍 |
Provides the possibility to report metrics to AWS using high resolution