Upgrade dependencies and fix unit tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azagniotov
reviewed
May 18, 2020
| @@ -598,11 +599,11 @@ private void buildReportWithSleep(final CloudWatchReporter.Builder cloudWatchRep | |||
| * | |||
| * @throws NoSuchFieldException | |||
| * @throws IllegalAccessException | |||
| * @see Meter#tickIfNecessary() | |||
| * @see ExponentialMovingAverages#tickIfNecessary() | |||
| * @see MetricDatum#getDimensions() | |||
| */ | |||
| private static void reduceMeterDefaultTickInterval() throws NoSuchFieldException, IllegalAccessException { | |||
There was a problem hiding this comment.
@madanepuri can you please provide some context about why this function has to be updated? Also, if it must to be updated, can you also update its name
There was a problem hiding this comment.
Also, please update the docs as you are changing the function behavior and this needs to be clearly communicated <= never mind, this is just a test
There was a problem hiding this comment.
@azagniotov TICK_INTERVAL field is moved to ExponentialMovingAverages class now. Previously it was in Meter class. Updated the function names. Please review. Thanks
madanepuri
force-pushed
the
dependency_upgrade
branch
from
47ec8c6
to
9a1dcbc
Compare
madanepuri
force-pushed
the
dependency_upgrade
branch
2 times, most recently
from
93f54b6
to
3f42df8
Compare
madanepuri
force-pushed
the
dependency_upgrade
branch
from
3f42df8
to
de54144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.