Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] ... Support ARM Docker Images #458

Closed
dnatic09 opened this issue Jan 6, 2023 · 14 comments
Closed

[FEATURE REQUEST] ... Support ARM Docker Images #458

dnatic09 opened this issue Jan 6, 2023 · 14 comments
Assignees

Comments

@dnatic09
Copy link

dnatic09 commented Jan 6, 2023

Is your feature request related to a problem? Please describe.
Docker images cannot run on ARM/M1 architecture

Describe the solution you'd like
Docker images to be published from CircleCI to Docker Hub with ARM support

Describe alternatives you've considered
I have tried emulation, but it is not nearly as good

Additional context

If circleci is running with buildx, you just need to change this line:
https://github.com/azagniotov/stubby4j/blob/master/.circleci/config.yml#L269

from:

 command: docker build --rm --no-cache -t azagniotov/stubby4j:latest-jre<< parameters.jdk_version >> .

to:

command: docker build --platform linux/amd64,linux/arm64,--rm --no-cache -t azagniotov/stubby4j:latest-jre<< parameters.jdk_version >> .
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Thanks for opening your first issue. Pull requests are always welcome too! :)

Copy link

stale bot commented Jan 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the wontfix label Jan 8, 2024
@dnatic09 dnatic09 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2024
@azagniotov
Copy link
Owner

azagniotov commented Jan 15, 2024 via email

@dnatic09
Copy link
Author

Thank you. We appreciate you circling back and closing this gap. It was difficult for Apple Silicon engineers to use this software previously without emulators or hacks.

@azagniotov
Copy link
Owner

No problem. I myself recently has moved to Apple Silicon. It will take me a few tries, please allow me sometime

@azagniotov
Copy link
Owner

I achieved some progress with publishing multiple arch images, see the latest-jre11: https://hub.docker.com/layers/azagniotov/stubby4j/latest-jre11/images/sha256-22a50332f75497b65a876ed245aefedda736c4e0b09dff81d389cc661240f0ca?context=explore

But, please do not use. I need to clean up the PR first: #465

@dnatic09
Copy link
Author

Not sure if it was on purpose or not. You broke the JDK16 image by using a JDK17 base image.

@azagniotov
Copy link
Owner

@dnatic09 apologies for the mix up. The JDK 16 latest image on Docker Hub has been reverted to its previous state

@dnatic09
Copy link
Author

No worries. Does not hurt my feelings either way. Just did not want other consumers to be confused.

@azagniotov
Copy link
Owner

Thank you for bringing this to my attention 👍🏼

@dnatic09
Copy link
Author

I see a JRE8 and JRE11 image on Docker Hub. Will JRE17 follow soon?

@azagniotov
Copy link
Owner

@dnatic09 right on time. The JRE 17 is up: https://hub.docker.com/r/azagniotov/stubby4j/tags

Would you be able to sanity check the ARM 64 images?

@azagniotov
Copy link
Owner

In the meanwhile, I will close the issue. Feel free to reopen

@dnatic09
Copy link
Author

@aservedio-swi, you can port the AV environments to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants