Dynamic token replacement in stubbed response has been applied for re…

[dzmitryh]

…sponse headers as well.

Hi There,

Yesterday faced with issue when I can't use token replacement in response headers. So for example I can't define regex group somewhere in request and then use it in response header like "location" but only in response body. So decided to fix it. Please advise in case of any concerns how to do it in the best way.

Thanks, Dzmitry.

[codecov-io]

Current coverage is 98.91% (diff: 100%)

Merging #63 into master will increase coverage by <.01%

@@             master        #63   diff @@
==========================================
  Files            38         38          
  Lines          1012       1015     +3   
  Methods           0          0          
  Messages          0          0          
  Branches        170        171     +1   
==========================================
+ Hits           1001       1004     +3   
  Misses            8          8          
  Partials          3          3          

Powered by Codecov. Last update 04a2a0b...660932c

[azagniotov]

Hi @dzmitryh ,
Thank you for your PR. That's pretty much the right place to do it. I do have a request for you before I merge it, would you be able to add a unit test for this use case? You can add the test(s) in unit/java/io/github/azagniotov/stubby4j/yaml/stubs/StubResponseTest.java

[dzmitryh]

Hi @azagniotov,

Thanks for letting me know about that!
I've added test to verify that scenario. Please check it out.

Thanks, Dima.

[azagniotov]

Awesome, thanks @dzmitryh !

[azagniotov]

Dima, just FYI - did a very very minor code cleanup in the areas where you touched the code, just some cosmetic refactoring.

[dzmitryh]

@azagniotov cool. Thanks so much!

[azagniotov]

@dzmitryh I just released version 4.0.5 (wait for Maven sync), in other words: your feature went live.

[dzmitryh]

Hi Alexander, That’s awesome! Thanks for such helpful tool btw ;) And Happy New Year! Thanks in advance, Dzmitry.

…

On Dec 30, 2016, at 8:31 PM, Alexander Zagniotov ***@***.***> wrote: @dzmitryh <https://github.com/dzmitryh> I just released version 4.0.5 (wait for Maven sync), in other words: your feature went live. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFJAnIOcgbbFi9QAXU3wOf2RK8rIyluuks5rNUAAgaJpZM4K7FM->.

[azagniotov]

Thank you! S Novim Nastupayushim Godom!