Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article search autocomplete #5

Closed
azaky opened this issue Oct 11, 2020 · 4 comments · Fixed by #9
Closed

Article search autocomplete #5

azaky opened this issue Oct 11, 2020 · 4 comments · Fixed by #9
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@azaky
Copy link
Owner

azaky commented Oct 11, 2020

Currently, the user has to type the full article name in the input box. It's nice to have a search autocomplete.

To give you an idea, this is the built-in search autocomplete in Wikipedia:

image

If one can reuse that, that's good. But creating for scratch is fine as well.

This is an API that you can use: https://en.wikipedia.org/w/api.php?action=opensearch&format=json&formatversion=2&search=book&namespace=0&limit=10

@azaky azaky added enhancement New feature or request good first issue Good for newcomers labels Oct 11, 2020
@muzavan
Copy link
Collaborator

muzavan commented Oct 11, 2020

Do we want to call wiki API directly or create a proxy in the wikigame server before call wiki API?

Wondering if we need additional process before calling Wiki API

(havent read the API though :p)

@azaky
Copy link
Owner Author

azaky commented Oct 11, 2020

I think using the existing wiki API is fine, as this is only for the autocomplete.

FYI, article validation on server side is already implemented here b26fbf1, so inputting values like "usa" will get automatically transformed to "United_States".

@muzavan
Copy link
Collaborator

muzavan commented Oct 12, 2020

Okay then, let me pick this up 🙏

@azaky
Copy link
Owner Author

azaky commented Oct 12, 2020

Thanks! Go ahead, looking forward to your PR!

@azaky azaky added this to the initial webstore publish milestone Oct 12, 2020
@muzavan muzavan mentioned this issue Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants