Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto complete #9

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Auto complete #9

merged 1 commit into from
Oct 14, 2020

Conversation

muzavan
Copy link
Collaborator

@muzavan muzavan commented Oct 12, 2020

Should resolve #5

@muzavan muzavan requested a review from azaky October 12, 2020 14:10
@muzavan
Copy link
Collaborator Author

muzavan commented Oct 13, 2020

@azaky please help to review.

As discussed, I use a similar component with Wikipedia's suggestion results. However, I find that the class styling for that component only triggered if we are input something in the Wikipedia search box, so I copy their CSS style and put it in the element style directly (e.g. here).

Please let me know if you have any feedback. Thanks!

@azaky
Copy link
Owner

azaky commented Oct 14, 2020

@muzavan this looks good! Have tried it locally. No problem with copying CSSs. Only one minor problem, I can't pick the search result by arrow keys, but I think that's not a problem if we don't handle it now.

Related to this, I have opened another pull request (#11) to reactify the content script. There, I exported ArticlePicker as a standalone component. I think this is better to be implemented there on top of the react version, what do you think? I suppose most of the changes in this PR can be copy-pasted right away to the react version.

@azaky azaky added this to the webstore publish milestone Oct 14, 2020
@muzavan muzavan merged commit e29fda9 into master Oct 14, 2020
@muzavan muzavan deleted the auto-complete branch October 14, 2020 10:36
@azaky
Copy link
Owner

azaky commented Oct 14, 2020

React version here: 13fd2dc

Note: I made changes to its behavior so that now the only acceptable input is from autocomplete (not from the free-typing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Article search autocomplete
2 participants