Avoid double-free on error in evbuffer_add_file. Found by coverity.

azat · Jul 26, 2012 · 6a81b1f · 6a81b1f
1 parent 6487f63
commit 6a81b1f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/buffer.c b/buffer.c
@@ -3184,7 +3184,8 @@ evbuffer_add_file(struct evbuffer *buf, int fd, ev_off_t offset, ev_off_t length
 	if (!seg)
 		return -1;
 	r = evbuffer_add_file_segment(buf, seg, 0, length);
-	evbuffer_file_segment_free(seg);
+	if (r == 0)
+		evbuffer_file_segment_free(seg);
 	return r;
 }