New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Timeless skin #401

Open
atlight opened this Issue Nov 24, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@atlight
Collaborator

atlight commented Nov 24, 2017

Unfortunately Twinkle requires a non-negligible amount of skin-specific logic to add its stuff to the UI (it's in twinkle.js). This means when a new skin comes out, we need to add special cases for it.

See https://phabricator.wikimedia.org/T181206 for some discussion related to this. For the time being we could simply treat Timeless like Monobook and add a set of links to the page actions portlet (p-pagetools in Timeless, p-cactions in Monobook). Eventually we should figure out how to implement a menu, as we did for Vector.

@evad37

This comment has been minimized.

evad37 commented Feb 12, 2018

This has actually been fixed in Timeless: https://phabricator.wikimedia.org/T181362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment