Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Timeless skin #401

Closed
atlight opened this issue Nov 24, 2017 · 7 comments
Closed

Support Timeless skin #401

atlight opened this issue Nov 24, 2017 · 7 comments

Comments

@atlight
Copy link
Collaborator

atlight commented Nov 24, 2017

Unfortunately Twinkle requires a non-negligible amount of skin-specific logic to add its stuff to the UI (it's in twinkle.js). This means when a new skin comes out, we need to add special cases for it.

See https://phabricator.wikimedia.org/T181206 for some discussion related to this. For the time being we could simply treat Timeless like Monobook and add a set of links to the page actions portlet (p-pagetools in Timeless, p-cactions in Monobook). Eventually we should figure out how to implement a menu, as we did for Vector.

@evad37
Copy link

evad37 commented Feb 12, 2018

This has actually been fixed in Timeless: https://phabricator.wikimedia.org/T181362

@siddharthvp
Copy link
Member

This can be closed now. Twinkle adds its menu options in Timeless in p-cactions which is a long menu in the right sidebar if viewport is wide enough, or a dropdown menu if not. This is much better and usable than the tabs of monobook and modern (before #721). There's no need to create a separate Twinkle menu.

@Amorymeltzer
Copy link
Collaborator

Amorymeltzer commented Oct 30, 2019

the right sidebar

left?

@Amorymeltzer
Copy link
Collaborator

I had left this open after speaking with Isarra, but agree with the above comments.

@siddharthvp
Copy link
Member

Its on the right, at least for me. Perhaps you're confusing with cologneblue?

@Amorymeltzer
Copy link
Collaborator

Perhaps you're confusing with cologneblue?

lol no. Definitely on the left for me, so I imagine it's just a responsive/whatever thing. 13-inch screen, Chrome.

@siddharthvp
Copy link
Member

Aha, I see. It jumps to the left when I make the window slightly smaller, and then disappears into a dropdown on making it still smaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants