-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Timeless skin #401
Comments
This has actually been fixed in Timeless: https://phabricator.wikimedia.org/T181362 |
This can be closed now. Twinkle adds its menu options in Timeless in |
left? |
I had left this open after speaking with Isarra, but agree with the above comments. |
Its on the right, at least for me. Perhaps you're confusing with cologneblue? |
lol no. Definitely on the left for me, so I imagine it's just a responsive/whatever thing. 13-inch screen, Chrome. |
Aha, I see. It jumps to the left when I make the window slightly smaller, and then disappears into a dropdown on making it still smaller. |
Unfortunately Twinkle requires a non-negligible amount of skin-specific logic to add its stuff to the UI (it's in twinkle.js). This means when a new skin comes out, we need to add special cases for it.
See https://phabricator.wikimedia.org/T181206 for some discussion related to this. For the time being we could simply treat Timeless like Monobook and add a set of links to the page actions portlet (
p-pagetools
in Timeless,p-cactions
in Monobook). Eventually we should figure out how to implement a menu, as we did for Vector.The text was updated successfully, but these errors were encountered: