arv: Note if reporting blocked users #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked version of wikimedia-gadgets#817, simply inserting some red text if the user being reported is (already) blocked. Closes wikimedia-gadgets#816 Co-authored-by: Amory Meltzer <Amorymeltzer@gmail.com>
This was referenced Nov 21, 2020
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Mar 3, 2021
…on checks Roughly matches the info displayed in arv as of wikimedia-gadgets#1184/wikimedia-gadgets#1204.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked version of #817, simply inserting some red text if the user being reported is (already) blocked. Closes #816.
@DannyS712: I just reconfigured your work there per my and @siddharthvp's comments, if you have a change to take a look over it that'd be great. This is noted as cloing #816, but FWIW it's a note not a confirmation, and doesn't take into account a user/IP that's blocked while filing out the form. That could be added but I didn't want to rewrite you too much.
Much like previously, I considered hiding it for SPI reports. It's still useful information so no reason not to show it, but I would hope it wouldn't discourage folks from filing appropriate SPI reports.