[ARV] Confirm reporting blocked users

[DannyS712]

Before proceeding to open the form, check if the relevant user is blocked or range blocked. If blocked, request confirmation.
The former "Twinkle.arv.callback" is now at "Twinkle.arv.callback.showform" - other than the portletLink, I didn't see any callers
Closes #816

[DannyS712]

Testing in developer tools:

• Delete the existing portlet
• Paste in the new code
• Call Twinkle.load()
  Tested with user blocked, IP blocked, range blocked, and no blocks, works

[Amorymeltzer]

Presumably this would be nicer after #765 ?

[DannyS712]

Not sure - this is based on code in checking for blocks elsewhere in the repo (don't remember where exactly) but morebits api may not be needed

[Amorymeltzer]

twinkleblock. No, it's not needed, but I believe it's the kind of thing that #765 would enable Morebits.wiki.api to handle (note: I haven't really reviewed #765). Not necessarily suggesting you change it, just noting its existence, especially given that it's an odd-one-out.

[Amorymeltzer]

Haven't tested yet but what are the merits of doing something like I (eventually came around to having) did in #757, specifically around #757 (comment)? We're more likely to not want to report someone with ARV if they are currently blocked, so I suppose the popup is more like to make sense here, but worth considering.

[Amorymeltzer]

Probably only needs to be added if isIP, right?

[DannyS712]

from what I recall, this is ignored if its not an IP

[Amorymeltzer]

Thoughts on the above, @DannyS712?

Also, twinklearv already has some mw.Apis, I think it'd be good to consolidate them.

Beyond that, do we really want to check for every option before loading? Notifying before reporting to AIV and UAA is good, they'll just get autoremoved otherwise. I guess AN3 as well, but do we definitely want to do this before SPI reporting? Especially for the sock option. I suppose it doesn't hurt much, but seems a waste, especially if it's going to be delaying opening the window.

Just thinking out loud: what about checking after the user has submitted the form? We could cancel if AIV/UAA, then check/notify for AN3/SPI. Does that make sense or am I mixed up?

[siddharthvp]

I too don't think it's good practise to put an API call that delays the opening of the form. One expects the something to open immediately when the they click the menu button. Using the red text option (as in #757) would be better IMO.

Also, is there a reason why mw.Api is used instead of morebits.wiki.api? The latter now supports JSON, so you can simply replace
new mw.Api().get(params).then(successFunc, failureFunc) with
new Morebits.wiki.api('Checking if already blocked', params, successFunc, null, failureFunc).post()

[Amorymeltzer]

Done in #1184