Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use of sensor id #66

Open
caseycesari opened this issue Feb 28, 2019 · 0 comments
Open

Refactor use of sensor id #66

caseycesari opened this issue Feb 28, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@caseycesari
Copy link
Contributor

caseycesari commented Feb 28, 2019

In various places in the code we reference the sensor id. We could clean-up our use of this by implementing the following:

  • Use a const to refer the property. In some cases we use Id and others id.
  • In some places we look up sensors by Location instead of id. See if we can use id everywhere.
  • Currently the id used as the key for the sensor data, and it is also stored a level down along with the sensor values. We shouldn't need to store it there. This could be addressed by Make changes to sensor state structure #64.
  • Generally confirm that the id property is used consistently.

Requires #64

@caseycesari caseycesari added 1 enhancement New feature or request and removed 1 labels Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant