Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify AOI box filtering behavior in sliding window datasets #1990

Closed
Tracked by #2084
chrisjkuch opened this issue Nov 16, 2023 · 1 comment 路 Fixed by #2088
Closed
Tracked by #2084

Allow user to specify AOI box filtering behavior in sliding window datasets #1990

chrisjkuch opened this issue Nov 16, 2023 · 1 comment 路 Fixed by #2088

Comments

@chrisjkuch
Copy link

馃殌 Feature

Add the ability to include chips in sliding window datasets that are only partially contained by the AOI.

Motivation

Currently, sliding window datasets only include a chip if the chip falls entirely within the specified AOI. It would be nice for complex AOI geometries to enable some overlap of chips with the AOI boundaries so that complete coverage within the AOI can be obtained.

Pitch

This should be a pretty minimal change (add a kwarg to the sliding window dataset and pass it through to the existing box-within checking here) and a great quality of life improvement for me personally.

@AdeelH
Copy link
Collaborator

AdeelH commented Nov 17, 2023

Agreed. I remember making this exact change a while ago for a specific project, but I guess it was never merged upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants