Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation tasks fail on ensemble_avg when using validation folds of different sizes #71

Closed
citerana opened this issue Jul 10, 2017 · 3 comments

Comments

@citerana
Copy link
Contributor

In an ensemble experiment that uses folds to get full coverage of the data set by using different validation sets, if the validation sets are not all of the same expected size then all the validation tasks will fail in the ensemble's aggregation job. This means that we cannot complete the following tasks: validation_probs, train_thresholds, train_predict, validation_predict or test_predict.

@lewfish
Copy link
Contributor

lewfish commented Jul 11, 2017

These tasks make the assumption that the validation and training sets are identical -- not just that they have the same cardinality. This is because there's no way to average together the probabilities of disjoint sets of samples. We probably want to disable these tasks when doing cross validation. However, the test_probs and test_predict methods should still work since cross validation doesn't affect the test set.

@lewfish
Copy link
Contributor

lewfish commented Jul 11, 2017

We still need a way to compute thresholds for the ensemble. Maybe we can average together the thresholds of the original model, or just use the train/validation split from one of the models.

@lewfish
Copy link
Contributor

lewfish commented Feb 12, 2018

This issue is no longer applicable to the current and future versions of Raster Vision.

@lewfish lewfish closed this as completed Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants