Locale fixes #25
Draft
Locale fixes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on rakudo/rakudo#3747 |
softmoth
force-pushed
the
locale-fixes
branch
3 times, most recently
from
2a9b576
to
5ba5eb4
Compare
Raku loves Unicode; we always want the wide-char version of the library
if available.
Also, prefer ncurses 6 over 5 if both are installed.
Don't export `library` routine. It is too common a name to leak out.
Instead, declare it as `our`s, so it can be called if explicitly
qualified with the module name (`NCurses::library()`).
Refactor to remove redundant logic for looking up libraries. Now the one
`library` function can look up all four libraries (`library('menu')`
works as you'd expect).
Cache library lookup in a state variable, only do a single `library-check`
call.
Move "LibraryCheck" from "test-depends" to "depends"; it is needed for
picking the right library (and already was, that's not new in this
patch).
See the 'Initialization' section of the ncurses(3x) man page. Also see locale(7) and setlocale(3) for details. Fixes issue azawawi#18 (as long as you use the ncursesw library).
Also remove the `delwin($win)` call; it frees memory of a window, and is typically not useful to call on stdscr. If it is called on stdscr, then calling refresh() after endwin() will likely fail. So people should read the docs before using delwin. Just calling endwin() on exit should be sufficient for almost all users. Also document the behavior when only RAKU_NCURSES_LIB is set. Also recommend apt-get libncurses6.
|
@softmoth Any update on this one? |
|
No, I'm not doing anything with Raku nowadays. Feel free to take anything from this that is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
setlocale