Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happiness of pet not visible #5

Closed
ghost opened this issue Apr 18, 2018 · 6 comments
Closed

Happiness of pet not visible #5

ghost opened this issue Apr 18, 2018 · 6 comments

Comments

@ghost
Copy link

ghost commented Apr 18, 2018

commit Beastmaster: e78d924
commit Azerothcore: azerothcore/azerothcore-wotlk@842ac4c
OS: Ubuntu 16.04

There's no icon indicating the pet's happiness for non-hunters, so it is very hard to know when to feed the pet. Is there perhaps an alternative?

@ghost
Copy link
Author

ghost commented Apr 24, 2018

I found some kind of workaround for this issue and included it to my latest commit: https://github.com/Stoabrogga/mod-npcbeastmaster/commit/e3fc47c7ab60a42f4e2e0e367837a0d0e9032338

I added a new config parameter "BeastMaster.KeepPetHappy". If set to 1 the pet gains maximum happiness with each attack. I used UnitScript to accomplish this, is this a legit way to implement it?

@BarbzYHOOL
Copy link
Member

Better chances of getting an answer in the discord

@ghost
Copy link
Author

ghost commented Apr 25, 2018

Sorry, but I don't want to join Discord due to privacy concerns.

I tested my changes and they are working very well, so I created a pull request for them.

@BarbzYHOOL
Copy link
Member

(You can use a temporary email for discord)

Ok, thank you for the PR

@ghost
Copy link
Author

ghost commented Apr 26, 2018

Well, ok, I'll give it a try :-)

@BarbzYHOOL
Copy link
Member

Fixed with #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant