Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login #5

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Login #5

merged 9 commits into from
Oct 23, 2023

Conversation

azerpas
Copy link
Owner

@azerpas azerpas commented Oct 20, 2023

Closes #2

@azerpas azerpas self-assigned this Oct 20, 2023
@azerpas azerpas closed this Oct 20, 2023
@azerpas azerpas reopened this Oct 20, 2023
@azerpas azerpas marked this pull request as draft October 20, 2023 18:50
@gitguardian
Copy link

gitguardian bot commented Oct 22, 2023

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8553062 Generic High Entropy Secret 19813fd src/bourso/client.rs View secret
8553062 Generic High Entropy Secret 19813fd src/bourso/client.rs View secret
8553062 Generic High Entropy Secret cdc0363 src/bourso/client.rs View secret
8553062 Generic High Entropy Secret cdc0363 src/bourso/client.rs View secret
8566878 Generic High Entropy Secret cdc0363 src/bourso/client.rs View secret
8566878 Generic High Entropy Secret cdc0363 src/bourso/client.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@azerpas azerpas marked this pull request as ready for review October 23, 2023 19:34
@azerpas azerpas merged commit bac08b7 into main Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a login module
1 participant