Org archive

[CodeMonk]

Couldn't figure out how to pull out an extra commit from master, so had to issue new pull request from branch.

Both your suggestions worked great.

[stockerman7]

NAVER - http://www.naver.com/

stockerman7@naver.com 님께 보내신 메일 <[PlainTasks] Org archive (#216)> 이 다음과 같은 이유로 전송 실패했습니다.

---

받는 사람이 회원님의 메일을 수신차단 하였습니다.

---

[vovkkk]

sublime.status_message(u'Archiving tree to {0}'.format(filename)) to support ST2, and all other strings should start with u and contain index for format.

[stockerman7]

NAVER - http://www.naver.com/

stockerman7@naver.com 님께 보내신 메일 <Re: [PlainTasks] Org archive (#216)> 이 다음과 같은 이유로 전송 실패했습니다.

---

받는 사람이 회원님의 메일을 수신차단 하였습니다.

---

[vovkkk]

You can commit and push in the same branch, it will be update here

[CodeMonk]

All changes made. Pushing.

I didn't branch before my work, and then I started working on my next little thing. I couldn't figure out how to remove a commit from master, for the pull request, and put that into a branch. So, instead, I branched at my commit for org-archive, and re-submitted the pull.

Sorry -- I'm normally a mercurial guy, and git has its nuances.

[vovkkk]

You forgot indexes {0}{1} instead of {}{} in formated strings, but alright I’ll merge by hand since need to update readme and tutorial too.

Thank you for pull request.

[CodeMonk]

Couple of questions:

I'm going to be adding a couple more changes. Should I file issue requests first to discuss them?

As to some of the compatibility stuff: unicode {0} vs {}, {} vs "%s" % str -- is there a style guide somewhere? Or, maybe just use pylint?

[vovkkk]

unicode {0} vs {}, {} vs "%s" % str -- is there a style guide somewhere? Or, maybe just use pylint?

I use ST2 as main editor, the best way to know, afaik, if code compatible is to run it in both versions; others incompatibilities out of head: filter() returns list in py2 and generator in py3, dictionary comprehension was added in py2.7.sth while ST2 has py2.6.sth so you have to use dict(), import module from same directory in ST3 has to start with dot import .module while in ST2 just import module, some ST API methods differs e.g. ST3 has view.is_valid() ST2 has no.

[CodeMonk]

Oh -- you actually had issues with ST2 -- I'll be sure and test changes on
both!

I just assumed you knew that {} gives issues on python 2.6

On Wed, Feb 25, 2015 at 2:46 PM, Vova Kolobok notifications@github.com
wrote:

unicode {0} vs {}, {} vs "%s" % str -- is there a style guide somewhere?
Or, maybe just use pylint?

I use ST2 as main editor, the best way to know, afaik, if code compatible
is to run it in both versions; others incompatibilities out of head:
filter() returns list in py2 and generator in py3, dictionary
comprehension was added in py2.7.sth while ST2 has py2.6.sth so you have to
use dict(), import module from same directory in ST3 has to start with
dot import .module while in ST2 just import module, some ST API methods
differs e.g. ST3 has view.is_valid() ST2 has no.

—
Reply to this email directly or view it on GitHub
#216 (comment).