Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update/refresh #119

Closed
aramk opened this issue May 31, 2016 · 7 comments
Closed

Auto-update/refresh #119

aramk opened this issue May 31, 2016 · 7 comments
Assignees

Comments

@aramk
Copy link

aramk commented May 31, 2016

It seems that the color added from git status doesn't update when changing files? I need to backspace out of the directory and back in for it to take effect?

@vovkkk
Copy link
Collaborator

vovkkk commented May 31, 2016

Yes, you can press r to refresh view.

Auto-update should be possible and this issue was raised previously, but the concern is performance, esp. in edge cases.

I think we are going to reach this goal sooner or later, let’s keep it open.

@aramk
Copy link
Author

aramk commented May 31, 2016

Ah ok, sounds good 👍 Pressing r key does work. Perhaps we can limit the git status call to only update for visible files, and when we expand a directory perhaps.

@vovkkk vovkkk self-assigned this Jul 5, 2016
@vovkkk vovkkk changed the title Git color not updating with file changes Auto-update/refresh Jul 5, 2016
@vovkkk
Copy link
Collaborator

vovkkk commented Jul 30, 2016

I’ve publish basic implementation in autorefresh branch, let’s test it.

Before publish it in master, we have to do following stuff (I hope to finish it in next couple of weeks):

  • fix all bugs, if any (please, report them here)
  • global disable of auto-refresh via user settings
  • per-view disable of auto-refresh via context menu
  • scheduling auto-refresh to prevent it happen more than once per second (or other suitable period of time, I’m not sure yet) — this is needed for good performance when a lot of stuff happens in folder, e.g. some process copy many files into it
  • add compiled fsevent module for watchdog into sublime-watchdog — this is needed for better performance on OS X, I’ve no Mac, so it’s up to you Mac-users.
  • make code pretty, refactor, all that jazz
  • fallback in case dependency(s) unavailable (e.g. in case SFB was installed manually)

@vovkkk
Copy link
Collaborator

vovkkk commented Aug 11, 2016

Any suggestions for ‘icons’ that show if current view is supposed to be automatically refreshed?

For now I take Ѻ and Ӝ
In sync
2016-08-11_16-17-35
Not in sync
2016-08-11_16-17-57

@aziz
Copy link
Owner

aziz commented Aug 11, 2016

These characters look weird. does it need to be on status bar? can't we just log it to the console?

@vovkkk
Copy link
Collaborator

vovkkk commented Aug 11, 2016

The reason was that I’ve put Toggle in context menu so these chars were supposed to help user understand what will happen, disable or enable.

Now I figured how to change caption on the fly, so no need to use status-bar.

@vovkkk
Copy link
Collaborator

vovkkk commented Aug 23, 2016

It seems ready in general, I’m going to release new version this Friday.

@vovkkk vovkkk closed this as completed in 4117c11 Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants