Filesystem - read_file - InvariantViolationException message should contains filename

[vaclavvanik]

Is your feature request related to a problem? Please describe.

When I try to read_file which does not exist, is not file or is not readable InvariantViolationException is thrown with message like $file does not exist.

I would like to see given filename in exception message. It's than easier to debug and fix possible problem.

Describe the solution you'd like

Replace

Psl\invariant(exists($file), '$file does not exist.');

with

Psl\invariant(exists($file), Str\format('File "%s" does not exist.', $file));

Thrown RuntimeException contains provided $file too.

[azjezz]

I'm pretty sure this is done in multiple other places as well.

would you like to send a PR? :)

[vaclavvanik]

Sure, I will create PR. Which branch should I target?

[azjezz]

1.8.x since it's not a bug :)

[azjezz]

Note: instead of Psl\invariant($fact, Str\format($message, ...$args)); you should do Psl\invariant($fact, $message, ...$args); ( the message will be formatted only if the $fact is false.