Filesystem - add argument values into InvariantViolationException message

[vaclavvanik]

I mentioned in #204 that thrown InvariantViolationException messages should contain argument values. It's easier to debug and fix code.

I updated everything I have found. Unit tests just updated. No additional unit tests added.

[azjezz]

Thank you for working on this 👍

[azjezz]

P.S: you can regenerate the docs using php docs/documentor.php.

[coveralls]

Pull Request Test Coverage Report for Build 903482522

• 24 of 24 (100.0%) changed or added relevant lines in 16 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 99.967%

---

Totals
Change from base Build 888968618:	0.0%
Covered Lines:	3064
Relevant Lines:	3065

---

💛 - Coveralls

[vaclavvanik]

I see inconsistency in input argument $file vs $filename. Almost everywhere is $filename. Just in

• append_file
• Internal\write_file
• read_file
• write_file

is $file. I am not sure which is better. But I do not want to rename it in this PR.

[azjezz]

yea, i can see how that is confusing, we should rename $filename to $path or $node, as everywhere else it means "file or directory", while the functions you mentioned explicitly require a file, not a directory.

[vaclavvanik]

Docs updated. I think I am done.

[azjezz]

make coding-standards-fix 😅

[azjezz]

Thank you @vaclavvanik!

[azjezz]

ops, doc needs another update ( you can run checks locally using make check ( now i see that it doesn't check documentation, probably need to update that later on )

[vaclavvanik]

I have updated docs. Now should be everything ok.