Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Str] Grapheme support #62

Closed
azjezz opened this issue Sep 29, 2020 · 2 comments · Fixed by #74
Closed

[Str] Grapheme support #62

azjezz opened this issue Sep 29, 2020 · 2 comments · Fixed by #74
Labels
hacktoberfest Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
0.1.0

Comments

@azjezz
Copy link
Owner

azjezz commented Sep 29, 2020 •
edited
Loading

Just like Psl\Str\Byte component, we want to add Psl\Str\Grapheme that wraps grapheme_str* function in a nicer API that is consistent with our Psl\Str and Psl\Str\Byte components.
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. Type: Enhancement Most issues will probably ask for additions or changes. labels Sep 29, 2020
@azjezz azjezz added this to the v1.0.0 milestone Sep 29, 2020
@azjezz azjezz self-assigned this Sep 29, 2020
@azjezz azjezz removed their assignment Sep 30, 2020
@davidribeiro
Copy link

He @azjezz
I can take care of this if you want

@azjezz
Copy link
Owner Author

azjezz commented Oct 1, 2020

Sure! that would be great!

@azjezz azjezz mentioned this issue Oct 3, 2020
Merged
@azjezz azjezz closed this as completed in #74 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

[Str] add grarpheme support azjezz/psl
2 participants
@davidribeiro @azjezz