[Str] add grarpheme support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
added
Status: In Progress
azjezz
force-pushed
the
feature/str-grapheme
branch
from
ac837f8
to
bdfca5e
Compare
azjezz
added
Status: Review Needed
azjezz
force-pushed
the
feature/str-grapheme
branch
from
bdfca5e
to
05b6b3c
Compare
azjezz
commented
Oct 3, 2020
src/Psl/Str/Grapheme/length.php
Outdated
| */ | ||
| function length(string $string): int | ||
| { | ||
| return (int) grapheme_strlen($string); |
There was a problem hiding this comment.
I think there's a case where grapheme_strlen returns null, not sure how to handle that.
There was a problem hiding this comment.
The docs state it always returns an int though:
https://www.php.net/manual/en/function.grapheme-strlen.php
(We could keep it - just to be sure :) )
There was a problem hiding this comment.
I learned to never belive the documentation 😆
see:
- https://github.com/php/php-src/blob/e73bf01f9d0c23dd5baed4445b37c93ec4e0ab29/ext/intl/php_intl.stub.php#L246
- https://github.com/php/php-src/blob/7af24eaedd310911940643d7a5f412393b973389/ext/intl/grapheme/grapheme_string.c#L84
- https://github.com/php/php-src/blob/7af24eaedd310911940643d7a5f412393b973389/ext/intl/grapheme/grapheme_string.c#L96
not sure how to handle these cases ...
There was a problem hiding this comment.
I added invariant violation checks.
azjezz
force-pushed
the
feature/str-grapheme
branch
2 times, most recently
from
a1d030c
to
9ec32cb
Compare
|
/cc @veewee If you think we can move ahead with this, let's merge it. |
azjezz
force-pushed
the
feature/str-grapheme
branch
from
9ec32cb
to
9f0bb13
Compare
Pull Request Test Coverage Report for Build 715
💛 - Coveralls |
azjezz
force-pushed
the
feature/str-grapheme
branch
from
9f0bb13
to
33fd4e2
Compare
veewee
previously approved these changes
Nov 2, 2020
src/Psl/Str/Grapheme/length.php
Outdated
| */ | ||
| function length(string $string): int | ||
| { | ||
| return (int) grapheme_strlen($string); |
There was a problem hiding this comment.
The docs state it always returns an int though:
https://www.php.net/manual/en/function.grapheme-strlen.php
(We could keep it - just to be sure :) )
azjezz
force-pushed
the
feature/str-grapheme
branch
3 times, most recently
from
3b0c554
to
f322e91
Compare
azjezz
force-pushed
the
feature/str-grapheme
branch
from
f322e91
to
bba7f5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #62
refs #63