split documentation #156
Merged
split documentation #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
added
Priority: Medium
Pull Request Test Coverage Report for Build 659902651
💛 - Coveralls |
|
also better checks!
|
veewee
approved these changes
Mar 17, 2021
| { | ||
| return [ | ||
| $components = [ |
There was a problem hiding this comment.
Future improvement is to try to guess all namespaces based on the folder structure (whilst removing the internal once).
There was a problem hiding this comment.
The main issue is with things like Psl\Str\Byte, Psl\Encoding\Hex .. etc.
| @@ -122,7 +111,7 @@ function get_namespace_documentation(string $namespace): string | |||
| } | |||
|
|
|||
| $definition_line = get_symbol_definition_line($symbol, $type); | |||
There was a problem hiding this comment.
The definition line for constants always return 0
Maybe we could use better-reflection to guess constants lines in the future.
There was a problem hiding this comment.
maybe later, for now it's not really important.
azjezz
added
Status: Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.