[Asio] Introduce Async I/O component #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
force-pushed
the
asio
branch
4 times, most recently
from
54cf6f4
to
345197d
Compare
BackEndTea
reviewed
Mar 21, 2021
|
|
||
| final class TimeoutException extends Exception\RuntimeException implements ExceptionInterface | ||
| { | ||
| public function __construct(string $message = 'operation timed out.', int $code = 0) |
There was a problem hiding this comment.
Should the exception expose how long it took?
There was a problem hiding this comment.
probably, will see ( this PR is not getting merged until PHP 8.1 is released, so there's still time to change the API 😛 )
azjezz
commented
Mar 21, 2021
src/Psl/Asio/stub.php
Outdated
Comment on lines
5
to
10
| if (false) { | ||
| final class Fiber | ||
| { | ||
| public function __construct(callable $c) | ||
| { | ||
| } |
There was a problem hiding this comment.
TODO: remove stub before merge
azjezz
force-pushed
the
asio
branch
3 times, most recently
from
8b308c5
to
c5cc9f4
Compare
veewee
reviewed
May 11, 2021
| * | ||
| * @internal | ||
| */ | ||
| public function onJoin(callable $callable): void; |
There was a problem hiding this comment.
Where does this method name come from?
In amp, they use on resolve, which is more clear IMO.
There was a problem hiding this comment.
This method ( maybe the whole class? ) is going to be removed soon thanks to some clever work by @:trowski and @:kelunik.
There was a problem hiding this comment.
Cool! Is it a loop / promise rfc to php-src perhaps? ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.