Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mismatching psalm assert variables #197

Merged
merged 1 commit into from
May 24, 2021
Merged

Fixed mismatching psalm assert variables #197

merged 1 commit into from
May 24, 2021

Conversation

dragosprotung
Copy link
Contributor

No description provided.

azjezz
azjezz previously approved these changes May 24, 2021
View reviewed changes
Copy link
Owner

@azjezz azjezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azjezz azjezz self-assigned this May 24, 2021
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels May 24, 2021
@azjezz azjezz changed the base branch from 1.8.x to 1.7.x May 24, 2021 19:59
@azjezz azjezz dismissed their stale review May 24, 2021 19:59

The base branch was changed.

@azjezz
Copy link
Owner

azjezz commented May 24, 2021

@dragosprotung can you please rebase against 1.7? i would like to release it there as a bug fix then merge up.

@coveralls
Copy link

coveralls commented May 24, 2021 •
edited

Pull Request Test Coverage Report for Build 872585079

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.967%
Totals Coverage Status
Change from base Build 856733043: 0.0%
Covered Lines: 2988
Relevant Lines: 2989
💛 - Coveralls

@dragosprotung
Copy link
Contributor Author

@dragosprotung can you please rebase against 1.7? i would like to release it there as a bug fix then merge up.

Done

@azjezz azjezz merged commit 0a2149e into azjezz:1.7.x May 24, 2021
@dragosprotung dragosprotung deleted the fix/mismatch-psalm-assert-variables branch May 24, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@azjezz azjezz

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dragosprotung @azjezz @coveralls