Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport static analysis fixes to 1.7 #221

Merged
merged 4 commits into from Aug 25, 2021
Merged

backport static analysis fixes to 1.7 #221

merged 4 commits into from Aug 25, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Aug 25, 2021

No description provided.

azjezz and others added 2 commits August 25, 2021 02:23
@azjezz
fix static analysis build
a8e01ab 
Signed-off-by: azjezz <azjezz@protonmail.com>
@caugner @azjezz
[Regex] fix replace_with() signature (#219)
4e711de 
* [Regex] Change replace_with $callback to accept string[]

The $matches array that is passed to `preg_replace_callback()`'s $callback 
can have string keys when the pattern uses named capture groups.

See: vimeo/psalm#5608
@azjezz azjezz added Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Available No one has claimed responsibility for resolving this issue. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Aug 25, 2021
@azjezz azjezz self-assigned this Aug 25, 2021
@azjezz azjezz added this to the 1.7.0 milestone Aug 25, 2021
@coveralls
Copy link

coveralls commented Aug 25, 2021 •
edited

Pull Request Test Coverage Report for Build 1164793800

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.967%
Totals Coverage Status
Change from base Build 872611573: 0.0%
Covered Lines: 2988
Relevant Lines: 2989
馃挍 - Coveralls

@azjezz azjezz merged commit 821391f into 1.7.x Aug 25, 2021
@azjezz azjezz deleted the fix/1.7/psalm-build branch September 8, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Available No one has claimed responsibility for resolving this issue. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@azjezz @coveralls @caugner @orklah