Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(async): always cancel timeout watcher after suspension is finished. #253

Merged
merged 1 commit into from
Nov 4, 2021
Merged

fix(async): always cancel timeout watcher after suspension is finished. #253

merged 1 commit into from
Nov 4, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Nov 4, 2021

Signed-off-by: azjezz azjezz@protonmail.com

@azjezz azjezz added Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: In Progress This issue is being worked on, and has someone assigned. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Nov 4, 2021
@azjezz azjezz added this to the 2.0.0 milestone Nov 4, 2021
@azjezz azjezz self-assigned this Nov 4, 2021
@coveralls
Copy link

coveralls commented Nov 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1419259332

  • 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1418953120: 0.0%
Covered Lines: 3072
Relevant Lines: 3072
💛 - Coveralls

@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 4, 2021
@azjezz azjezz merged commit e3d8830 into 2.0.x Nov 4, 2021
@azjezz azjezz deleted the fix/timeout branch November 4, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azjezz @coveralls